-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add proxysettings for azureopenai and openai #415
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2ea60a3
to
9e78c71
Compare
We are waiting for this proxy setting feature in next k8sgpt-operator release. Currently it does not take proxyEndpoint in k8sgpt CRD spec. Thanks in advance for moving this forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tanujd11 , a few comments:
- Update the docs to include the new spec's attribute
- I was checking the k8sgpt's PR that we merged recently, we missed to surface the
proxyEndpoint
as a cli argument , feel free to add it if you want - You have to update manually the helm's chart CRD template to include the
proxyEndpoint:
type: string
@tanujd11 just bumping a message, changes lgtm but please update README's example to include the new spec attribute you are creating π |
Closes #307
π Description
This PR adds proxyEndpoint to be configured from the operator. The feature was provided by k8sgpt-ai/k8sgpt#987 in k8sgpt.
β Checks
βΉ Additional Information